[Data] Preserve block format on map_batches over empty blocks
#38161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogkam
requested review from
ericl,
scv119,
c21,
scottjlee,
bveeramani and
raulchen
as code owners
c21
reviewed
Aug 7, 2023
| @@ -105,6 +106,12 @@ def process_next_batch(batch: DataBatch) -> Iterator[Block]: | |||
| else: | |||
| raise e from None | |||
|
|
|||
| try: | |||
| first_block = next(blocks) | |||
There was a problem hiding this comment.
This would hold the an extra block in-memory during execution, right? To avoid the increased memory overhead, can we create the corresponding output block builder here?
There was a problem hiding this comment.
No I don't think it will hold any extra memory? We're not copying the block anywhere. There's always just one reference to the block.
There was a problem hiding this comment.
hmm, but in this case, the first block is always living in object store memory, until the map_batches is finished, right? because we hold the reference here.
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…project#38161) Preserve the original block format when calling map_batches over empty blocks. Previously, map_batches would default to always outputting an Arrow block regardless of the format of the input empty blocks. Changing the underlying block format for empty blocks can lead to the dataset having multiple block formats, which does not work for sort or aggregation operations. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…project#38161) Preserve the original block format when calling map_batches over empty blocks. Previously, map_batches would default to always outputting an Arrow block regardless of the format of the input empty blocks. Changing the underlying block format for empty blocks can lead to the dataset having multiple block formats, which does not work for sort or aggregation operations. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…project#38161) Preserve the original block format when calling map_batches over empty blocks. Previously, map_batches would default to always outputting an Arrow block regardless of the format of the input empty blocks. Changing the underlying block format for empty blocks can lead to the dataset having multiple block formats, which does not work for sort or aggregation operations. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…project#38161) Preserve the original block format when calling map_batches over empty blocks. Previously, map_batches would default to always outputting an Arrow block regardless of the format of the input empty blocks. Changing the underlying block format for empty blocks can lead to the dataset having multiple block formats, which does not work for sort or aggregation operations. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…project#38161) Preserve the original block format when calling map_batches over empty blocks. Previously, map_batches would default to always outputting an Arrow block regardless of the format of the input empty blocks. Changing the underlying block format for empty blocks can lead to the dataset having multiple block formats, which does not work for sort or aggregation operations. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve the original block format when calling
map_batchesover empty blocks. Previously,map_batcheswould default to always outputting an Arrow block regardless of the format of the input empty blocks. Changing the underlying block format for empty blocks can lead to the dataset having multiple block formats, which does not work for sort or aggregation operations.Why are these changes needed?
Related issue number
Closes #37963
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.