Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Lazily construct metadata providers #38198

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

Currently, we use mutable defaults for the meta_provider parameters. This PR updates the implementation to construct new metadata providers for each function call.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani merged commit 375d0b0 into master Aug 8, 2023
60 of 63 checks passed
@bveeramani bveeramani deleted the lazy-load-metadata branch August 8, 2023 05:10
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
Currently, we use mutable defaults for the meta_provider parameters. This PR updates the implementation to construct new metadata providers for each function call.

Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Currently, we use mutable defaults for the meta_provider parameters. This PR updates the implementation to construct new metadata providers for each function call.

Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Currently, we use mutable defaults for the meta_provider parameters. This PR updates the implementation to construct new metadata providers for each function call.
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Currently, we use mutable defaults for the meta_provider parameters. This PR updates the implementation to construct new metadata providers for each function call.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Currently, we use mutable defaults for the meta_provider parameters. This PR updates the implementation to construct new metadata providers for each function call.

Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants