[Data] Remove unnecessary filesystem wrapping #38299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee and
raulchen
as code owners
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
scottjlee
approved these changes
Aug 10, 2023
shrekris-anyscale
pushed a commit
to shrekris-anyscale/ray
that referenced
this pull request
Aug 10, 2023
In FileBasedDatasource.write, we wrap then immediately unwrap the filesystem object. Since there's no point in wrapping the filesystem object, this PR removes the line. For context, this logic is likely from legacy code that was refactored by ray-project#37986. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
In FileBasedDatasource.write, we wrap then immediately unwrap the filesystem object. Since there's no point in wrapping the filesystem object, this PR removes the line. For context, this logic is likely from legacy code that was refactored by ray-project#37986. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
In FileBasedDatasource.write, we wrap then immediately unwrap the filesystem object. Since there's no point in wrapping the filesystem object, this PR removes the line. For context, this logic is likely from legacy code that was refactored by ray-project#37986. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
In FileBasedDatasource.write, we wrap then immediately unwrap the filesystem object. Since there's no point in wrapping the filesystem object, this PR removes the line. For context, this logic is likely from legacy code that was refactored by ray-project#37986. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
In FileBasedDatasource.write, we wrap then immediately unwrap the filesystem object. Since there's no point in wrapping the filesystem object, this PR removes the line. For context, this logic is likely from legacy code that was refactored by ray-project#37986. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
In FileBasedDatasource.write, we wrap then immediately unwrap the filesystem object. Since there's no point in wrapping the filesystem object, this PR removes the line. For context, this logic is likely from legacy code that was refactored by ray-project#37986. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In
FileBasedDatasource.write, we wrap then immediately unwrap thefilesystemobject. Since there's no point in wrapping thefilesystemobject, this PR removes the line. For context, this logic is likely from legacy code that was refactored by #37986.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.