[train] Storage: Call callbacks with new checkpoint #38456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
justinvyu
reviewed
Aug 15, 2023
| @@ -1074,7 +1074,7 @@ def clear_checkpoint(self): | |||
| self.temporary_state.restoring_from = None | |||
| self.run_metadata.invalidate_cache() | |||
|
|
|||
| def on_checkpoint(self, checkpoint: _TrackedCheckpoint): | |||
| def on_checkpoint(self, checkpoint: Union[_TrackedCheckpoint, _TrainingResult]): | |||
There was a problem hiding this comment.
Ahh I haven't been so on top of updating all of these 😄
ericl
reviewed
Aug 15, 2023
ericl
added
the
@author-action-required
added 2 commits
August 16, 2023 11:56
Signed-off-by: Kai Fricke <kai@anyscale.com>
…checkpoint # Conflicts: # python/ray/tune/execution/tune_controller.py
krfricke
commented
Aug 16, 2023
| saved_iter = "?" | ||
| if trial.last_result and TRAINING_ITERATION in trial.last_result: | ||
| saved_iter = trial.last_result[TRAINING_ITERATION] | ||
|
|
||
| self._start_block(f"trial_{trial}_result_{saved_iter}") | ||
|
|
||
| if isinstance(checkpoint, Checkpoint): | ||
| loc = f"({checkpoint.filesystem.type_name}){checkpoint.path}" |
There was a problem hiding this comment.
We currently have no way to restore the actual location URI, so this is the next best thing.
There was a problem hiding this comment.
add an example of what this looks like in the pr description?
krfricke
removed
the
@author-action-required
justinvyu
added
the
tests-ok
justinvyu
approved these changes
Aug 16, 2023
| saved_iter = "?" | ||
| if trial.last_result and TRAINING_ITERATION in trial.last_result: | ||
| saved_iter = trial.last_result[TRAINING_ITERATION] | ||
|
|
||
| self._start_block(f"trial_{trial}_result_{saved_iter}") | ||
|
|
||
| if isinstance(checkpoint, Checkpoint): | ||
| loc = f"({checkpoint.filesystem.type_name}){checkpoint.path}" |
There was a problem hiding this comment.
add an example of what this looks like in the pr description?
ericl
added
the
@author-action-required
|
Good to merge, but just in case you want to address the nits. |
ericl
removed
the
tests-ok
added 2 commits
August 17, 2023 11:05
Signed-off-by: Kai Fricke <kai@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Adjust checkpoint interface to accept new-style checkpoint objects instead. In progress reporter output: ``` Training saved a checkpoint for iteration 4 at: (s3)bucket/foo/bar ``` Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Adjust checkpoint interface to accept new-style checkpoint objects instead. In progress reporter output: ``` Training saved a checkpoint for iteration 4 at: (s3)bucket/foo/bar ``` Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adjust checkpoint interface to accept new-style checkpoint objects instead.
In progress reporter output:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.