[ci/train] Add Ray Train storage refactor CI tests #38457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2023 14:06
Signed-off-by: Kai Fricke <kai@anyscale.com>
justinvyu
reviewed
Aug 15, 2023
.buildkite/pipeline.ml.yml
Outdated
|
|
||
| ##### STORAGE REFACTOR | ||
|
|
||
| - label: ":steam_locomotive: Train tests and examples" |
There was a problem hiding this comment.
I think we also need to add:
- 📖 Doc tests and examples (excluding Ray AIR examples)
✈️ AIR tests (ray/air)✈️ AIR/ML release smoke tests
GPU:
- 📺
✈️ AIR GPU tests (ray/air) - 📺 🚂 Train GPU tests
Doctest would also probably fail.
There was a problem hiding this comment.
Ok sounds good - I'll first take a stab with the current selection but can update later/soon.
There was a problem hiding this comment.
Got it, should we coordinate with a spreadsheet and shard the fixes?
There was a problem hiding this comment.
Also, let's update the names of these Train / Train + Tune ones to also be prefixed by "New persistence mode:"
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
This PR adds CI runners for the Ray Train and Tune tests with the new storage context path enabled. Many tests are excluded at first. We will iteratively work on enabling them to avoid having to fix a bunch of issues in one giant PR. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
This PR adds CI runners for the Ray Train and Tune tests with the new storage context path enabled. Many tests are excluded at first. We will iteratively work on enabling them to avoid having to fix a bunch of issues in one giant PR. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds CI runners for the Ray Train and Tune tests with the new storage context path enabled.
Many tests are excluded at first. We will iteratively work on enabling them to avoid having to fix a bunch of issues in one giant PR.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.