Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Add partition_filter parameter to read_parquet #38479

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Aug 15, 2023

Why are these changes needed?

If your dataset contains any non-parquet files, read_parquet errors. To workaround this, this PR adds a partition_filter parameter so users can ignore non-parquet files.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Initial commit

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
python/ray/data/datasource/parquet_datasource.py Outdated Show resolved Hide resolved
python/ray/data/datasource/parquet_datasource.py Outdated Show resolved Hide resolved
python/ray/data/tests/test_parquet.py Outdated Show resolved Hide resolved
Address review comments

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Address review comments

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. let's test with user before merging, thanks.

@bveeramani bveeramani merged commit 4cf94ba into master Aug 22, 2023
55 of 58 checks passed
@bveeramani bveeramani deleted the bveeramani/parquet-filter branch August 22, 2023 20:18
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…t#38479)

If your dataset contains any non-parquet files, read_parquet errors. To workaround this, this PR adds a partition_filter parameter so users can ignore non-parquet files.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…t#38479)

If your dataset contains any non-parquet files, read_parquet errors. To workaround this, this PR adds a partition_filter parameter so users can ignore non-parquet files.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants