[air] New train.Checkpoint API: Update lightning, transformers, and tf integrations
#38491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
justinvyu
force-pushed
the
air/update_trainers
branch
from
1e66990
to
f265479
Compare
woshiyyya
approved these changes
Aug 16, 2023
|
@woshiyyya Good point. I'll add that as a todo on the issue. I think we can add these legacy methods on the base |
justinvyu
added
the
tests-ok
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
… tf integrations (ray-project#38491) Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
… tf integrations (ray-project#38491) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
… tf integrations (ray-project#38491) Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
… tf integrations (ray-project#38491) Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR updates
LightningTrainer,TransformersTrainer, and the TF/KerasReportCheckpointCallbackto report a newFrameworkCheckpoint(from #38452) when the feature flag is enabled. The callbacks for the new torch integration APIs are also updated to return a newCheckpointrather than the oldair.Checkpoint.This PR also makes
Backend._encode_dataa noop for all frameworks. This is not needed with the new checkpoints.Notes
Checkpointbecause the lightning/transformers trainers are being deprecated soon, and it's ok to just keep the legacy behavior for them. (Otherwise, there'd be a bunch of unnecessary updates to make.)TensorflowCheckpointinReportCheckpointCallback. This is because it's also a checkpoint that we create for the user, so the user may need some accessors to get stuff out of it. Another option is to add a getter toReportCheckpointCallback(similar toXGBoostTrainer.get_model) and just return a genericCheckpoint.Related issue number
#38292
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.