[serve] Clean up asyncio.Events used in LongPollHost when the client times out
#38516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
edoakes
changed the title
asyncio.Events used in LongPollHost when the client times out
shrekris-anyscale
approved these changes
Aug 16, 2023
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…ent times out (ray-project#38516) We currently leak `asyncio.Event`s when: - Clients time out waiting for updates. - `notify_changed` is never called for that key. This change removes the events when the timeout happens on the `LongPollHost`. Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…ent times out (ray-project#38516) We currently leak `asyncio.Event`s when: - Clients time out waiting for updates. - `notify_changed` is never called for that key. This change removes the events when the timeout happens on the `LongPollHost`.
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ent times out (ray-project#38516) We currently leak `asyncio.Event`s when: - Clients time out waiting for updates. - `notify_changed` is never called for that key. This change removes the events when the timeout happens on the `LongPollHost`. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ent times out (ray-project#38516) We currently leak `asyncio.Event`s when: - Clients time out waiting for updates. - `notify_changed` is never called for that key. This change removes the events when the timeout happens on the `LongPollHost`. Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We currently leak
asyncio.Events when:notify_changedis never called for that key.This change removes the events when the timeout happens on the
LongPollHost.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.