[train] Storage: Update XGBoost + LightGBM callback APIs #38558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2023 16:13
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
added 2 commits
August 17, 2023 19:07
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
added 2 commits
August 17, 2023 22:48
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
8 tasks
justinvyu
approved these changes
Aug 21, 2023
Comment on lines
86
to
87
| _checkpoint_callback_cls = None | ||
| _report_callbacks_cls = None |
There was a problem hiding this comment.
We check if these properties are set for backwards compatibility with xgboost-ray and lightgbm-ray (and also for sequencing the API update).
We could test this also with getattr but it makes the code that invokes them more cluttered.
added 6 commits
August 21, 2023 16:46
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…#38558) The APIs are currently still using the deprecated `tune.checkpoint_dir` context manager and `tune.report`. This PR updates XGBoost+LightGBM to use `train.report` instead. It also consolidates the available callbacks into one. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…#38558) The APIs are currently still using the deprecated `tune.checkpoint_dir` context manager and `tune.report`. This PR updates XGBoost+LightGBM to use `train.report` instead. It also consolidates the available callbacks into one. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The APIs are currently still using the deprecated
tune.checkpoint_dircontext manager andtune.report.This PR updates XGBoost+LightGBM to use
train.reportinstead. It also consolidates the available callbacks into one.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.