Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update getting-started-pytorch-lightning.rst #38563

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

angelinalg
Copy link
Contributor

made some edits for concision

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

made some edits for concision

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
@@ -3,7 +3,7 @@
Getting Started with PyTorch Lightning
======================================

This tutorial will walk you through the process of converting an existing PyTorch Lightning script to use Ray Train.
This tutorial walks through the process of converting an existing PyTorch Lightning script to use Ray Train.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you apply the same changes to the other getting started guides that follow the same format (Torch, Transformers)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

angelinalg and others added 5 commits August 24, 2023 12:14
Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>
Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>
@angelinalg angelinalg added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 25, 2023
@angelinalg angelinalg added Ray 2.7 docs An issue or change related to documentation labels Aug 25, 2023
@angelinalg angelinalg changed the title Update getting-started-pytorch-lightning.rst [docs] Update getting-started-pytorch-lightning.rst Aug 25, 2023
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean docs change

@zhe-thoughts zhe-thoughts merged commit adb4545 into master Aug 25, 2023
13 of 15 checks passed
@zhe-thoughts zhe-thoughts deleted the angelinalg-patch-2 branch August 25, 2023 23:48
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
* Update getting-started-pytorch-lightning.rst

made some edits for concision

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>

* copy edits to pytorch-based guides

Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>

* copy edits

Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>

---------

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>
Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>
Co-authored-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>
Co-authored-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
* Update getting-started-pytorch-lightning.rst

made some edits for concision

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>

* copy edits to pytorch-based guides

Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>

* copy edits

Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>

---------

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>
Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>
Co-authored-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>
Co-authored-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
* Update getting-started-pytorch-lightning.rst

made some edits for concision

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>

* copy edits to pytorch-based guides

Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>

* copy edits

Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>

---------

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>
Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>
Co-authored-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>
Co-authored-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
* Update getting-started-pytorch-lightning.rst

made some edits for concision

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>

* copy edits to pytorch-based guides

Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>

* copy edits

Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>

---------

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>
Signed-off-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>
Co-authored-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local.meter>
Co-authored-by: angelina <angelina@kelvin-test-GV9VPVHXNQ.local>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation Ray 2.7 tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants