Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] migrate AIR API references #38632

Merged
merged 7 commits into from
Aug 21, 2023

Conversation

matthewdeng
Copy link
Contributor

Why are these changes needed?

This PR disbands the AIR API References page. Most API references were already defined within their individual libraries.

Additional changes include:

  1. Move Preprocessors to Data.
  2. Move Wandb/MLflow/Comet LoggerCallbacks to Tune.

Related issue number

#38365

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Deng <matt@anyscale.com>
@amogkam
Copy link
Contributor

amogkam commented Aug 19, 2023

Are we removing all the non-tabular preprocessor API references from the documentation?

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@@ -0,0 +1,3 @@
from ray.air.integrations.comet import CometLoggerCallback

CometLoggerCallback.__module__ = "ray.tune.logger.comet"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not totally sure what this does, so skipping this part of the review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just makes the path show up properly

>>> from ray.tune.logger.comet import CometLoggerCallback
>>> CometLoggerCallback
<class 'ray.tune.logger.comet.CometLoggerCallback'>

doc/source/tune/tutorials/tune_get_data_in_and_out.md Outdated Show resolved Hide resolved
@@ -1,25 +0,0 @@

Ray AIR Configurations
======================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this already got moved to train?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the configs are in the Train/Tune API references already.


Experiment Tracking Integrations
================================

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this file moved to train?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callbacks are in Tune, and we are choosing to not recommend to setup methods

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng matthewdeng merged commit 4b37161 into ray-project:master Aug 21, 2023
62 of 65 checks passed
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants