Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[air] Remove train_mlflow_example throughout. #38656

Merged
merged 2 commits into from
Aug 21, 2023
Merged

[air] Remove train_mlflow_example throughout. #38656

merged 2 commits into from
Aug 21, 2023

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Aug 21, 2023 •
edited
Loading

Not reflecting the best practice, which will be reflected in the coming user guide.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010
Remove train_mlflow_example throughout.
269da3a 
Not reflecting the best practice.

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
matthewdeng
matthewdeng reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please ping again once build passes

doc/source/train/examples/mlflow_fashion_mnist_example.rst Show resolved Hide resolved
@xwjiang2010
remove all
496ea65 
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
@xwjiang2010 xwjiang2010 merged commit 299ae25 into ray-project:master Aug 21, 2023
45 of 47 checks passed
@xwjiang2010 xwjiang2010 deleted the remove_mlflow_train_mnist branch August 21, 2023 20:23
@pcmoritz
Copy link
Contributor

@xwjiang2010 Why not also remove the associated .py file of the example?

@xwjiang2010
Copy link
Contributor Author

@xwjiang2010 Why not also remove the associated .py file of the example?

oops, my bad. Opening another PR here: #38696

arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@xwjiang2010 @arvind-chandra
[air] Remove train_mlflow_example throughout. (ray-project#38656)
64c61ef 
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@xwjiang2010
[air] Remove train_mlflow_example throughout. (ray-project#38656)
82851fa 
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@krfricke krfricke Awaiting requested review from krfricke

@amogkam amogkam Awaiting requested review from amogkam

@Yard1 Yard1 Awaiting requested review from Yard1

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

Assignees

@matthewdeng matthewdeng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xwjiang2010 @pcmoritz @matthewdeng