[Data] Apply limit to Dataset.take() and related methods
#38677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, let's publish the PR. |
8 tasks
scottjlee
requested review from
ericl,
scv119,
c21,
amogkam,
bveeramani and
raulchen
as code owners
raulchen
approved these changes
Aug 21, 2023
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ct#38677) To improve the efficiency of common Dataset access methods such as Dataset.take(), .take_batch(), .show(), etc., we can apply a Limit before taking rows for these methods to avoid materializing more rows than requested by the user. Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ct#38677) To improve the efficiency of common Dataset access methods such as Dataset.take(), .take_batch(), .show(), etc., we can apply a Limit before taking rows for these methods to avoid materializing more rows than requested by the user. Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To improve the efficiency of common Dataset access methods such as Dataset.take(), .take_batch(), .show(), etc., we can apply a Limit before taking rows for these methods to avoid materializing more rows than requested by the user.
Related issue number
Original PR (closed due to bad rebase): #38597
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.