[tune] Remove the URI parsing code #38697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
ericl
changed the title
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
justinvyu
reviewed
Aug 23, 2023
| @@ -91,6 +93,15 @@ def experiment_path(self) -> str: | |||
| location (path on the head node).""" | |||
| return self._experiment_analysis.experiment_path | |||
|
|
|||
| @property | |||
| def filesystem(self) -> pyarrow.fs.FileSystem: | |||
There was a problem hiding this comment.
keep this named storage_filesystem? fine either way.
There was a problem hiding this comment.
I think it's best to be consistent with checkpoint, which uses filesystem as the attribute.
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
ericl
force-pushed
the
remove-uri-parsing
branch
from
e0edc5e
to
44ebf99
Compare
ericl
added
Ray 2.7
tests-ok
|
The failing test is flaking on master with the exact same error message. @zhe-thoughts can you merge? This is needed to flip on the new persistence backend. |
zhe-thoughts
approved these changes
Aug 24, 2023
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Eric Liang <ekhliang@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Signed-off-by: Eric Liang <ekhliang@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Closes #38568