[Data] Avoid passing local_uri to all non-Parquet data sources
#38719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Su <scnju13@gmail.com>
c21
requested review from
ericl,
scv119,
amogkam,
scottjlee,
bveeramani and
raulchen
as code owners
c21
changed the title
local_uri to all non-Parquet data sources
bveeramani
approved these changes
Aug 22, 2023
scottjlee
approved these changes
Aug 22, 2023
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…-project#38719) This is followup of ray-project#38496, to fix local read for all non-Parquet data sources. After this PR, all data sources should be able to do local read without issue. Signed-off-by: Cheng Su <scnju13@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…-project#38719) This is followup of ray-project#38496, to fix local read for all non-Parquet data sources. After this PR, all data sources should be able to do local read without issue. Signed-off-by: Cheng Su <scnju13@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is followup of #38496, to fix local read for all non-Parquet data sources. After this PR, all data sources should be able to do local read without issue.
Related issue number
Closes #35133
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.