Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air] New train.Checkpoint API: Update Train + tune tests and examples #38770

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

justinvyu
Copy link
Contributor

Why are these changes needed?

This PR converts the following tests to use the new FF:

tune_torch_regression_example
transformers_example_cpu
test_tune

Still need to convert tune_cifar_torch_pbt_example, pending PBT support.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 23, 2023
@justinvyu justinvyu removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 23, 2023
@justinvyu
Copy link
Contributor Author

@krfricke Ok to merge

Signed-off-by: Kai Fricke <krfricke@users.noreply.github.com>
@krfricke krfricke merged commit 666e59a into ray-project:master Aug 23, 2023
41 of 44 checks passed
@justinvyu justinvyu deleted the air/persistence/ci/train_tune branch August 23, 2023 17:28
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…ples` (ray-project#38770)

This PR converts the following tests to use the new FF:

tune_torch_regression_example
transformers_example_cpu
test_tune

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Kai Fricke <krfricke@users.noreply.github.com>
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…ples` (ray-project#38770)

This PR converts the following tests to use the new FF:

tune_torch_regression_example
transformers_example_cpu
test_tune

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Kai Fricke <krfricke@users.noreply.github.com>
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants