Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core][1/3] Make streaming generator public API #38784

Merged
merged 17 commits into from
Nov 27, 2023
Merged

[Core][1/3] Make streaming generator public API #38784

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
239a63a
Done
rkooo567 Aug 23, 2023
4492b41
clean up.
rkooo567 Aug 23, 2023
bf36e5f
Merge branch 'master' into streaming-generator-public-api
rkooo567 Aug 24, 2023
6d2a0bf
Addressed code review.
rkooo567 Aug 24, 2023
4379f9f
Merge branch 'master' into streaming-generator-public-api
rkooo567 Aug 24, 2023
2086104
Addressed code review.
rkooo567 Aug 25, 2023
1a7360d
ip
Nov 20, 2023
28d5355
remove typing
Nov 20, 2023
4400194
streaming-generator-public-api
Nov 20, 2023
8f35359
Merge branch 'master' into streaming-generator-public-api
Nov 21, 2023
a9a78b7
Fix issues.
Nov 21, 2023
bf26864
Fixed.
Nov 21, 2023
9211dc4
.
Nov 22, 2023
e05281b
Remove typing changes
Nov 22, 2023
0cfdfd8
done
Nov 22, 2023
7829e42
Merge branch 'master' into streaming-generator-public-api
Nov 27, 2023
ebd8238
done
Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions python/ray/_private/ray_option_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,10 @@ def issubclass_safe(obj: Any, cls_: type) -> bool:
(int, str, type(None)),
lambda x: None
if (x is None or x == "dynamic" or x == "streaming" or x >= 0)
else "The keyword 'num_returns' only accepts None, a non-negative integer, or "
'"dynamic" (for generators)',
default_value=1,
else "Default None. The keyword 'num_returns' only accepts None, "
"a non-negative integer, or "
'"dynamic" (for generators). "dynamic" is deprecated from Ray 2.7.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'"dynamic" (for generators). "dynamic" is deprecated from Ray 2.7.',
'"streaming" (for generators). "dynamic" is deprecated from Ray 2.7.',

?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the default value is not 1 but None, what does None mean here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me update the comment. None basically means default.

Default behavior is 1 for regular task, and streaming for a generator task

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the comment. Please take a look and lmk what you think

default_value=None,
rkooo567 marked this conversation as resolved.
Show resolved Hide resolved
),
"object_store_memory": Option( # override "_common_options"
(int, type(None)),
Expand Down
Loading
Loading