Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[train] New persistence mode: Support the tune.run(restore="ckpt_path") API #38804

Merged

Conversation

justinvyu
Copy link
Contributor

@justinvyu justinvyu commented Aug 23, 2023

Why are these changes needed?

tune.run(restore="/path/to/local/checkpoint") previously didn't work. This PR allows you to resume training a single trial from a checkpoint. However, this does NOT load back the training iteration from before. It just starts from scratch with the checkpoint. It's more similar to Trainer(resume_from_checkpoint) now. This is a behavior change due to the "trainable metadata" (including the training iter) no longer being saved within the checkpoint.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 24, 2023
@justinvyu justinvyu added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Aug 24, 2023
@justinvyu
Copy link
Contributor Author

@krfricke ok to merge if looks good. Are you ok with the slight API behavior change here?

@ericl
Copy link
Contributor

ericl commented Aug 24, 2023

ping @zhe-thoughts for approval for 2.7

@ericl ericl added the Ray 2.7 label Aug 24, 2023
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after approval from @zhe-thoughts

python/ray/tune/experiment/trial.py Show resolved Hide resolved
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of Train API clean up

@zhe-thoughts
Copy link
Collaborator

@krfricke or @ericl : is CI OK?

@zhe-thoughts
Copy link
Collaborator

Checked with @aslonnie and confirmed CI is OK

1 similar comment
@zhe-thoughts
Copy link
Collaborator

Checked with @aslonnie and confirmed CI is OK

@zhe-thoughts zhe-thoughts merged commit d5e324d into ray-project:master Aug 24, 2023
56 of 64 checks passed
@justinvyu justinvyu deleted the air/persistence/trial_restore branch August 24, 2023 18:10
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…h")` API (ray-project#38804)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
…h")` API (ray-project#38804)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…h")` API (ray-project#38804)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ray 2.7 tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants