Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train] Turn on new persistence mode by default #38844

Merged
merged 15 commits into from
Aug 25, 2023
Merged

[train] Turn on new persistence mode by default #38844

merged 15 commits into from
Aug 25, 2023

Conversation

justinvyu
Copy link
Contributor

@justinvyu justinvyu commented Aug 24, 2023 •
edited by matthewdeng
Loading

Why are these changes needed?

This changes the default value of RAY_AIR_NEW_PERSISTENCE_MODE from 0 to 1.

Additionally, this sets RAY_AIR_NEW_PERSISTENCE_MODE=0 for CI tests that are not updated to the new API yet.

As immediate follow-up, we will fix the tests and stop setting this environment variable throughout the codebase.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@justinvyu
FLIP
4803e25 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@matthewdeng
Merge branch 'master' of github.com:ray-project/ray into air/persiste…
ca8c7dc 
…nce/flip_ff
@matthewdeng
Merge branch 'master' of github.com:ray-project/ray into air/persiste…
0daf159 
…nce/flip_ff
@matthewdeng
[all_tests]
eccaeeb 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
Merge branch 'air/persistence/flip_ff' of github.com:justinvyu/ray in…
b935e9d 
…to air/persistence/flip_ff
@matthewdeng
[all_tests]
7515991 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
whitespace to trigger tests
e7c79ad 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
set RAY_AIR_NEW_PERSISTENCE_MODE=0 for non-migrated tests
28e8a7b 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
Merge branch 'master' into air/persistence/flip_ff
36d245b 
Signed-off-by: matthewdeng <matt@anyscale.com>
@matthewdeng
fix
b0fe5ef 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
fix
1810b83 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
fix
ae0f6d6 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
fix
f547361 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
Merge branch 'master' of github.com:ray-project/ray into air/persiste…
08df773 
…nce/flip_ff
@matthewdeng
fix
a0f90a4 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng matthewdeng marked this pull request as ready for review August 25, 2023 23:32
@matthewdeng matthewdeng added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 25, 2023
zhe-thoughts
zhe-thoughts approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary Train change for 2.7

@zhe-thoughts zhe-thoughts merged commit 19ec5b5 into ray-project:master Aug 25, 2023
99 of 117 checks passed
@matthewdeng matthewdeng mentioned this pull request Aug 27, 2023
Merged
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@justinvyu @matthewdeng @arvind-chandra
[train] Turn on new persistence mode by default (ray-project#38844)
a8d5e8a 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: matthewdeng <matt@anyscale.com>
Co-authored-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
@justinvyu @matthewdeng @LeonLuttenberger
[train] Turn on new persistence mode by default (ray-project#38844)
ec7568f 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: matthewdeng <matt@anyscale.com>
Co-authored-by: Matthew Deng <matt@anyscale.com>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
@justinvyu @matthewdeng @jimthompson5802
[train] Turn on new persistence mode by default (ray-project#38844)
9a84949 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: matthewdeng <matt@anyscale.com>
Co-authored-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@justinvyu @matthewdeng
[train] Turn on new persistence mode by default (ray-project#38844)
de223aa 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: matthewdeng <matt@anyscale.com>
Co-authored-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

Assignees

@matthewdeng matthewdeng

@zhe-thoughts zhe-thoughts

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinvyu @matthewdeng @zhe-thoughts