Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[train] alias train.Checkpoint to new Checkpoint #38864

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Aug 25, 2023

Why are these changes needed?

When using the new storage path, ray.train.Checkpoint will point to ray.train._checkpoint.Checkpoint instead of ray.air.Checkpoint.

RAY_AIR_NEW_PERSISTENCE_MODE=0 python -c "import ray.train; print(ray.train.Checkpoint)"
<class 'ray.air.checkpoint.Checkpoint'>
RAY_AIR_NEW_PERSISTENCE_MODE=1 python -c "import ray.train; print(ray.train.Checkpoint)"
<class 'ray.train._checkpoint.Checkpoint'>

nit: Will update __module__ in a future PR.

Related issue number

#38571

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng matthewdeng marked this pull request as ready for review August 25, 2023 01:55
@matthewdeng matthewdeng added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 25, 2023
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Train API cleanup

@zhe-thoughts zhe-thoughts merged commit f3f518c into ray-project:master Aug 25, 2023
41 of 45 checks passed
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
* [train] alias train.Checkpoint

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
* [train] alias train.Checkpoint

Signed-off-by: Matthew Deng <matt@anyscale.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
* [train] alias train.Checkpoint

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants