Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train] enable new persistence mode for doctests #38876

Merged
merged 5 commits into from
Aug 25, 2023
Merged

[train] enable new persistence mode for doctests #38876

merged 5 commits into from
Aug 25, 2023

Conversation

matthewdeng
Copy link
Contributor

Why are these changes needed?

Updates the Doctest (CPU) and Doctest (GPU) to use the new checkpoint persistence mode.

Notes:

  1. For batch inference, we showcase the new XGBoostTrainer.get_model static method.
  2. For ray.air.Checkpoint, we use the original ray.air import. This is okay because ray.train.Checkpoint will point to ray.train._checkpoint.Checkpoint when the new path is on.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@matthewdeng
[train] enable new persistence mode for doctests
cb22965 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
fix
9345fd3 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
fix
6dbe472 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
fix
d56c145 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng
fix
67420a4 
Signed-off-by: Matthew Deng <matt@anyscale.com>
amogkam
amogkam approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@matthewdeng matthewdeng added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 25, 2023
@zhe-thoughts zhe-thoughts merged commit 8c72ec0 into ray-project:master Aug 25, 2023
70 of 73 checks passed
@matthewdeng matthewdeng mentioned this pull request Aug 27, 2023
Merged
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@matthewdeng @arvind-chandra
[train] enable new persistence mode for doctests (ray-project#38876)
4c00640 
* [train] enable new persistence mode for doctests

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
@matthewdeng @LeonLuttenberger
[train] enable new persistence mode for doctests (ray-project#38876)
71aa5d2 
* [train] enable new persistence mode for doctests

Signed-off-by: Matthew Deng <matt@anyscale.com>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
@matthewdeng @jimthompson5802
[train] enable new persistence mode for doctests (ray-project#38876)
c1a1f20 
* [train] enable new persistence mode for doctests

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@matthewdeng
[train] enable new persistence mode for doctests (ray-project#38876)
53bd6e6 
* [train] enable new persistence mode for doctests

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@krfricke krfricke krfricke approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@c21 c21 Awaiting requested review from c21 c21 is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@richardliaw richardliaw Awaiting requested review from richardliaw

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@Yard1 Yard1 Awaiting requested review from Yard1

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

Assignees

@justinvyu justinvyu

@zhe-thoughts zhe-thoughts

@woshiyyya woshiyyya

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matthewdeng @amogkam @zhe-thoughts @krfricke @justinvyu @woshiyyya