Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Update pytorch-lightning integration API (#38883) #38985

Merged
merged 1 commit into from
Aug 28, 2023
Merged

[tune] Update pytorch-lightning integration API (#38883) #38985

merged 1 commit into from
Aug 28, 2023

Conversation

krfricke
Copy link
Contributor

Updates PTL callbacks to use new train.report API.

Why are these changes needed?

Pick of #38883

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke @matthewdeng @justinvyu
[tune] Update pytorch-lightning integration API (ray-project#38883)
0dfa4b7 
Updates PTL callbacks to use new train.report API.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: matthewdeng <matthew.j.deng@gmail.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
Co-authored-by: Justin Yu <justinvyu@anyscale.com>
zhe-thoughts
zhe-thoughts approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's pick

@GeneDer GeneDer merged commit 1797458 into ray-project:releases/2.7.0 Aug 28, 2023
55 of 63 checks passed
@krfricke krfricke deleted the 2.7.0/pick/ptl branch September 22, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@matthewdeng matthewdeng Awaiting requested review from matthewdeng

Assignees

@matthewdeng matthewdeng

@zhe-thoughts zhe-thoughts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krfricke @zhe-thoughts @matthewdeng @GeneDer