[data][fault tolerance] Do not eagerly free root RefBundles #39016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee and
bveeramani
as code owners
ericl
reviewed
Aug 28, 2023
| cleaned_metadata(read_task), | ||
| ) | ||
| ], | ||
| owns_blocks=True, |
There was a problem hiding this comment.
If you set owns_blocks=False that would also equivalently prevent them from being freed.
There was a problem hiding this comment.
Though, it sounds like we'd like to free them at the end of the workload, just not as soon as possible, so there is some subtlety here.
There was a problem hiding this comment.
yes, owns_blocks=False is the right fix. at the end of the workload, they will be eventually freed by python GC. and their sizes are small. So it should be fine.
raulchen
changed the title
raulchen
changed the title
ericl
approved these changes
Aug 29, 2023
c21
reviewed
Aug 29, 2023
c21
approved these changes
Aug 29, 2023
amogkam
approved these changes
Aug 29, 2023
raulchen
added a commit
to raulchen/ray
that referenced
this pull request
Aug 29, 2023
…ect#39016) Fix the issue that we eagerly free the root RefBundles. This bug broke fault tolerance. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
8 tasks
GeneDer
pushed a commit
that referenced
this pull request
Aug 30, 2023
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ect#39016) Fix the issue that we eagerly free the root RefBundles. This bug broke fault tolerance. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger
pushed a commit
to jaidisido/ray
that referenced
this pull request
Sep 5, 2023
…ect#39016) Fix the issue that we eagerly free the root RefBundles. This bug broke fault tolerance. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
…ect#39016) Fix the issue that we eagerly free the root RefBundles. This bug broke fault tolerance. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ect#39016) Fix the issue that we eagerly free the root RefBundles. This bug broke fault tolerance. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix the issue that we eagerly free the root RefBundles. This bug broke fault tolerance.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.