Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release][core][autoscaler] Autoscaler e2e release tests [1/x] #39046

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Aug 29, 2023

Why are these changes needed?

Add a release test for testing autoscaler related APIs/scenarios e2e with actual node providers, rather than mocks.

There should be 3 PRs including this:

  1. This PR: added the basic test skeleton and example tests (for core's request_cluster_resources and running tasks/actors for upscaling, as well idle termination)
  2. PR 2: add more test cases including various test scenarios of PGs, node failures, library workloads (e.g. serve)
  3. PR 3: add metrics for tracking scaling performance (number of nodes to start, time to start a node)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Attention: External code changed

A previous version of this PR changed code that is used or cited in external sources, e.g. blog posts.

It looks like these changes have been reverted or are otherwise not present in this PR anymore. Please still carefully review the changes to make sure code we use in external sources still works.

Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx changed the title autoscaler e2e [release][core][autoscaler] Autoscaler e2e release tests [1/x] Aug 29, 2023
@rickyyx rickyyx marked this pull request as ready for review August 29, 2023 21:16
@rickyyx
Copy link
Contributor Author

rickyyx commented Aug 29, 2023

@rickyyx rickyyx marked this pull request as draft August 29, 2023 22:47
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx marked this pull request as ready for review August 30, 2023 21:33
@rickyyx rickyyx merged commit 8094bda into ray-project:master Sep 13, 2023
84 of 89 checks passed
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 15, 2023
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…roject#39046)

---------

Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants