[data] Removing unnecessary data copy in convert_udf_returns_to_numpy #39188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee and
bveeramani
as code owners
c21
approved these changes
Aug 31, 2023
| @@ -488,7 +488,10 @@ def _concat_same_type( | |||
| [e for a in to_concat for e in a] | |||
| ) | |||
| else: | |||
| storage = pa.concat_arrays([c.storage for c in to_concat]) | |||
| if len(to_concat) == 1: | |||
| storage = to_concat[0].storage | |||
There was a problem hiding this comment.
can we add a comment for why this is needed, for reader in the future.
There was a problem hiding this comment.
It turns out that the PyArrow Block copy code path expects this function to copy data. I reverted this change in this PR, as it doesn't impact the final benchmark perf.
This reverts commit 75b7581. Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
changed the title
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Sep 8, 2023
…ray-project#39188) --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
…ray-project#39188) --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ray-project#39188) --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This increases the perf of
image_loader_microbenchmark.pyby ~10%.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.