Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[train][2.7][2/n] cherry-picks for documentations, tests, examples #39195

Merged
merged 16 commits into from
Sep 1, 2023

Conversation

matthewdeng
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

woshiyyya and others added 16 commits August 31, 2023 21:32
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
… (small)` (ray-project#39047)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Our API change from `tune.report()` to `train.report()` can lead to namespace clashes when the training function is called `train`.

This has been an issue in many test migrations, including ray-project#39050 and the current failure of ray-project#38493.

This PR does a global replace of all training function defined as `def train(config)` with `def train_fn(config)` to avoid future clashes.

Signed-off-by: Kai Fricke <kai@anyscale.com>
…oject#39096)

Re-organize data loading performance tips. We want the caching and the CPU nodes sections to be together since they are both addressing the same problems of optimizing performance when you have expensive CPU preprocessing, and the latter references the former.

Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com>
…PI. (ray-project#39014)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
…endencies (ray-project#39049)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Removes remaining calls to checkpoint.dir_or_data in the wandb/comet integrations

Signed-off-by: Kai Fricke <kai@anyscale.com>
…r`, and `reporter` (ray-project#39093)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…g Example (ray-project#39117)

Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
…-project#38009)

Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
…ity with `RAY_CHDIR_TO_TRIAL_DIR` env var (ray-project#39107)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary for 2.7

@matthewdeng matthewdeng marked this pull request as ready for review September 1, 2023 14:33
@matthewdeng matthewdeng added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 1, 2023
@GeneDer GeneDer merged commit 71c4117 into ray-project:releases/2.7.0 Sep 1, 2023
118 of 123 checks passed
@matthewdeng matthewdeng deleted the train-2.7 branch September 7, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants