-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[train][2.7][2/n] cherry-picks for documentations, tests, examples #39195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
… (small)` (ray-project#39047) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Our API change from `tune.report()` to `train.report()` can lead to namespace clashes when the training function is called `train`. This has been an issue in many test migrations, including ray-project#39050 and the current failure of ray-project#38493. This PR does a global replace of all training function defined as `def train(config)` with `def train_fn(config)` to avoid future clashes. Signed-off-by: Kai Fricke <kai@anyscale.com>
…oject#39096) Re-organize data loading performance tips. We want the caching and the CPU nodes sections to be together since they are both addressing the same problems of optimizing performance when you have expensive CPU preprocessing, and the latter references the former. Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com>
…oject#39108) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…PI. (ray-project#39014) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
…endencies (ray-project#39049) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Removes remaining calls to checkpoint.dir_or_data in the wandb/comet integrations Signed-off-by: Kai Fricke <kai@anyscale.com>
…r`, and `reporter` (ray-project#39093) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…g Example (ray-project#39117) Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com> Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
…-project#39121) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…-project#38009) Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com> Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
…ity with `RAY_CHDIR_TO_TRIAL_DIR` env var (ray-project#39107) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…project#39187) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
zhe-thoughts
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary for 2.7
matthewdeng
requested review from
richardliaw,
gjoliver,
krfricke,
xwjiang2010,
amogkam,
Yard1,
maxpumperla and
a team
as code owners
September 1, 2023 14:33
matthewdeng
requested review from
sven1977,
avnishn,
ArturNiederfahrenhorst,
smorad and
kouroshHakha
as code owners
September 1, 2023 14:33
matthewdeng
added
the
tests-ok
The tagger certifies test failures are unrelated and assumes personal liability.
label
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.