Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve][Doc] Add handle instruction to send multiplex request #39274

Merged
merged 14 commits into from
Sep 7, 2023

Conversation

sihanwang41
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
@sihanwang41 sihanwang41 marked this pull request as ready for review September 5, 2023 22:26
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions.

doc/source/serve/deploy-many-models/model-multiplexing.md Outdated Show resolved Hide resolved
doc/source/serve/deploy-many-models/model-multiplexing.md Outdated Show resolved Hide resolved
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
@edoakes
Copy link
Contributor

edoakes commented Sep 7, 2023

@sihanwang41 docs build and premerge failed. Neither look related, rebasing to retry CI.

@sihanwang41
Copy link
Contributor Author

retry works, ping to merge. @edoakes

@edoakes edoakes merged commit 3e7c8af into ray-project:master Sep 7, 2023
20 checks passed
sihanwang41 added a commit to sihanwang41/ray that referenced this pull request Sep 7, 2023
harborn pushed a commit to harborn/ray that referenced this pull request Sep 8, 2023
GeneDer pushed a commit that referenced this pull request Sep 8, 2023
#39402)

Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
…oject#39274)

Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…oject#39274)

Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants