-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Unpin pyarrow from test-requirements #39290
Conversation
Signed-off-by: Scott Lee <sjl@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @scottjlee,
unfortunately this doesn't have an effect on the actual installed dependencies as python/requirements_compiled.txt
is still pinning pyarrow.
Instead, after applying your change, you should run ./ci/ci.sh compile_pip_dependencies
on a Linux machine with Python 3.8 to re-compile the dependencies.
(Ideally you can also do the same for Python 3.7 with ./ci/ci.sh compile_pip_dependencies requirements_compiled_py37.txt
).
Let me know if you need any support with that.
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
I've updated the PR with a new compiled requirements file. So far it looks good, we'll just have to see if all tests are passing. |
Potentially we need to re-add a pyarrow 6 test, depending on if we want to continue to test support for it. |
Signed-off-by: Kai Fricke <kai@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the PR and tests seem to be passing. Would be good to get another pair of eyes on cc @matthewdeng
Signed-off-by: Kai Fricke <kai@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good assuming this was generated in clean environment.
Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com>
* [Data] Unpin pyarrow from test-requirements (#39290) Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> * Update requirements_compiled.txt * Update test-requirements.txt --------- Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Co-authored-by: matthewdeng <matt@anyscale.com> Co-authored-by: Gene Der Su <e870252314@gmail.com>
Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Why are these changes needed?
When installing ray, we found that pyarrow 6.0.1 is installed, while our default requirements.txt and other requirements files specify pyarrow >= 6.0.1 or higher. So, we try removing the pinned
pyarrow==6.0.1
intest-requirements.txt
to see if this is still necessary. We expect that if this is no longer needed, removing this pin will allow the resolved pyarrow version to be higher than Arrow 6, since pyarrow is already installed from the default requirements.txt, and there is a manual Arrow version override for Data tests already. This will allow users to fully utilize critical pyarrow 7+ features out of the gate, without having to manually install a higher version of Arrow.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.