[Core]: Enable get_actor_name for actor runtime context #39347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-anyscale
requested review from
a team,
edoakes,
shrekris-anyscale,
sihanwang41,
zcin,
architkulkarni,
wuisawesome,
DmitriGekhtman,
maxpumperla,
pcmoritz,
kevin85421,
ericl,
justinvyu,
matthewdeng and
sofianhnaide
as code owners
added 2 commits
September 6, 2023 15:39
Signed-off-by: Jonathan Nitisastro <jonathannitisastro@jonathancn-QC69NQYVVG.local.meter>
jonathan-anyscale
force-pushed
the
expose_actor_name
branch
from
8dce9ed
to
7649c27
Compare
jonathan-anyscale
removed request for
a team,
ericl,
pcmoritz,
maxpumperla,
justinvyu and
matthewdeng
jonathan-anyscale
removed request for
architkulkarni,
sihanwang41,
edoakes,
zcin,
kevin85421,
DmitriGekhtman,
shrekris-anyscale and
sofianhnaide
rkooo567
reviewed
Sep 7, 2023
| @@ -346,6 +346,19 @@ def foo(self): | |||
| ray.get(actor.foo.remote()) | |||
|
|
|||
|
|
|||
| def test_actor_name(ray_start_regular): | |||
There was a problem hiding this comment.
nit can you just add this test in the previous test test_ids? Having a new suite will do ray.init which is pretty slow (and I think this test is too small, so it is probably better just piggybacking to the previous test)
There was a problem hiding this comment.
Gotcha! I merged it with the test_ids
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
…_name Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
…into expose_actor_name Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
rkooo567
reviewed
Sep 11, 2023
python/ray/runtime_context.py
Outdated
|
|
||
| Returns: | ||
| The current actor name of this worker. | ||
| Return empty string if there's no actor name or if it's a driver |
There was a problem hiding this comment.
This docstring is inconsistent.
If it is a driver == if it is not an actor
but it says
if it is a driver -> empty string
if it is not an actor -> None.
Can you update the docstring to
If a current worker is an actor, and if actor name doesn't exist, it returns an empty string.
If a current worker is not an actor, it returns None.
| assert ray.get(named_actor.name.remote()) == ACTOR_NAME | ||
|
|
||
| # unnamed actor name | ||
| unnamed_actor = NamedActor.options().remote() |
There was a problem hiding this comment.
Can you add tests to verify all the specs from the API?
Make sure if it is a task, it returns "None".
Make sure if it is a driver, it returns "None".
Make sure if it has no actor name, it returns "".
Make sure if it is an actor and has a name, it returns the name
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
rkooo567
approved these changes
Sep 11, 2023
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
…39347) Expose current actor's name through RuntimeContext() Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Sep 12, 2023
…39347) Expose current actor's name through RuntimeContext() Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…39347) Expose current actor's name through RuntimeContext() Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Expose current actor's name through
RuntimeContext()Related issue number
Closes #35849
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.