[release byod] fix ml requirements file selection #39353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one more place that I found about picking ml-or-not that is based on the old "cpu-or-not" logic. |
aslonnie
force-pushed
the
lonnie-0906-mlrequire
branch
from
c4a2bce
to
e42da28
Compare
aslonnie
commented
Sep 6, 2023
| @@ -251,15 +251,15 @@ def get_byod_image_tag(self) -> str: | |||
| } | |||
| return f"{self.get_byod_base_image_tag()}-{dict_hash(custom_info)}" | |||
|
|
|||
| def _use_byod_ml_image(self) -> bool: | |||
| def use_byod_ml_image(self) -> bool: | |||
There was a problem hiding this comment.
maybe if using ml image should have it's own field? like technically speaking, we also have ray-ml:cpu image, just never used in release tests..
|
this probably only affects @xwjiang2010 's new test. |
can-anyscale
approved these changes
Sep 7, 2023
release/ray_release/byod/build.py
Outdated
| if test.get_byod_type() == "cpu" | ||
| else f"{REQUIREMENTS_ML_BYOD}_{test.get('python', PYTHON_VERSION)}.txt" | ||
| ) | ||
| py_version = test.get("python", PYTHON_VERSION) |
There was a problem hiding this comment.
nit: test.get_python_version()
There was a problem hiding this comment.
done.. why were you not using that in the past?
and also change ecr to registry, as it might be google's too. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-0906-mlrequire
branch
from
e42da28
to
fbcb2c2
Compare
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Sep 8, 2023
and also change ecr to registry, as it might be google's too. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
and also change ecr to registry, as it might be google's too. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
and also change ecr to registry, as it might be google's too. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also change ecr to registry, as it might be google's too.