[ci] jail //python/ray/serve:test_websockets #39375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: can <can@anyscale.com>
can-anyscale
force-pushed
the
can-serve-flaky
branch
from
bc8e99e
to
9617618
Compare
aslonnie
approved these changes
Sep 7, 2023
do you have a pr/link/something that we can track the progress of the fixing? |
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Sep 8, 2023
it has become very flaky recently. Signed-off-by: can <can@anyscale.com>
|
Hi @aslonnie and @can-anyscale looks like the test is not being run. here is my pr triggering the test: https://buildkite.com/ray-project/premerge/builds/5248#018a71c9-6550-4f3e-bd16-12bbe7132bfc |
|
the test did run, but in 3 parallel dockers, and only one has tests. |
aslonnie
reviewed
Sep 8, 2023
| instance_type: medium | ||
| soft_fail: true | ||
| commands: | ||
| - bazel run //ci/ray_ci:test_in_docker -- //... serve --run-flaky-tests --parallelism-per-worker 3 |
There was a problem hiding this comment.
@sihanwang41 , your PR #39413 seems to have fixed the test, so you can revert this PR's change in your PR.
- maybe remove the
--parallelism-per-worker 3? - and/or fix the issue of running 0 tests in a parallel container.
|
oops my bad, I'll fix the 0 test issues |
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
it has become very flaky recently. Signed-off-by: can <can@anyscale.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
it has become very flaky recently. Signed-off-by: can <can@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//python/ray/serve:test_websockets is becoming very flaky, jail it
Test: