Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add an ad for Ray Summit 2023 #39404

Merged
merged 1 commit into from
Sep 8, 2023
Merged

[Doc] Add an ad for Ray Summit 2023 #39404

merged 1 commit into from
Sep 8, 2023

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented Sep 7, 2023 •
edited
Loading

Why are these changes needed?

This PR adds banners for the Ray Summit in the sidebar of the docs and in the github README.rst.

Once the Ray Summit is over, we can just remove the line from docs/source/conf.py that includes the summit.js, and that will remove the banner. For next year, we can just replace the contents of the embedded SVG in summit.js.

Related issue number

Closes #39436.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@peytondmurray peytondmurray added the docs An issue or change related to documentation label Sep 7, 2023
@peytondmurray peytondmurray requested a review from a team as a code owner September 7, 2023 20:17
@peytondmurray
[Doc] Add an ad for Ray Summit 2023
777e2bf 
Signed-off-by: pdmurray <peynmurray@gmail.com>
angelinalg
angelinalg approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @peytondmurray !

@angelinalg angelinalg mentioned this pull request Sep 8, 2023
Closed
@matthewdeng matthewdeng merged commit 7da798f into ray-project:master Sep 8, 2023
105 of 112 checks passed
angelinalg pushed a commit to angelinalg/ray that referenced this pull request Sep 8, 2023
@peytondmurray @angelinalg
[Doc] Add an ad for Ray Summit 2023 (ray-project#39404)
ac8d4d2 
Signed-off-by: pdmurray <peynmurray@gmail.com>
@peytondmurray peytondmurray deleted the docs-add-summit-link branch September 8, 2023 04:49
pcmoritz pushed a commit that referenced this pull request Sep 8, 2023
@angelinalg @peytondmurray
[Doc] Add an ad for Ray Summit 2023 (#39404) (#39439)
29f21ee 
Signed-off-by: pdmurray <peynmurray@gmail.com>
Co-authored-by: Peyton Murray <peynmurray@gmail.com>
@angelinalg angelinalg mentioned this pull request Sep 8, 2023
Merged
8 tasks
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
@peytondmurray @jimthompson5802
[Doc] Add an ad for Ray Summit 2023 (ray-project#39404)
c7f971b 
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@peytondmurray
[Doc] Add an ad for Ray Summit 2023 (ray-project#39404)
6fc7109 
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
@rickyyx rickyyx mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg approved these changes

Assignees
No one assigned
Labels
docs An issue or change related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Add banner to Ray docs and Ray project repo about Ray Summit
4 participants
@peytondmurray @angelinalg @matthewdeng @zhe-thoughts