-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] jail //python/ray/data:test_streaming_executor #39423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyao
approved these changes
Sep 7, 2023
can-anyscale
commented
Sep 7, 2023
commands: | ||
- bazel run //ci/ray_ci:test_in_docker -- //... data --run-flaky-tests | ||
--test-env RAY_DATA_USE_STREAMING_EXECUTOR=1 --parallelism-per-worker 3 | ||
depends_on: data12build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that we only test flaky tests with arrow 12
aslonnie
approved these changes
Sep 7, 2023
bveeramani
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
can-anyscale
force-pushed
the
can-data-flaky
branch
from
September 7, 2023 23:53
e7c67a0
to
73cb8b3
Compare
Signed-off-by: can <can@anyscale.com>
can-anyscale
force-pushed
the
can-data-flaky
branch
from
September 8, 2023 01:09
73cb8b3
to
cd98987
Compare
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
Signed-off-by: can <can@anyscale.com> Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Signed-off-by: can <can@anyscale.com> Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//python/ray/data:test_streaming_executor becomes flaky after we move it to civ2; jail it for now whlie we investigate the root cause
@bveeramani to jail (soft-fail) a test, you can just put a test target to the corresponding data.tests.yml file like in this PR
Test: