Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue 39234: Multi categorical dist bugs tf and torch. #39464

Merged
merged 6 commits into from
Sep 9, 2023
Merged

[RLlib] Issue 39234: Multi categorical dist bugs tf and torch. #39464

merged 6 commits into from
Sep 9, 2023

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Sep 8, 2023 •
edited
Loading

See issue #39234

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
fix
5000e4c 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
fix
1a4b094 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into issu…
5c23e47 
…e_39411_torch_multi_dist_bug
@sven1977
fix
41ebdaf 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
ArturNiederfahrenhorst
ArturNiederfahrenhorst approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we are lacking quite a bit of code coverage here :/

@sven1977
LINT
bede0c1 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' into issue_39234_torch_multi_discrete_dist_bugs…
594236f 
…_tf_and_torch
@sven1977 sven1977 merged commit f438fe5 into ray-project:master Sep 9, 2023
38 of 41 checks passed
@sven1977 sven1977 deleted the issue_39234_torch_multi_discrete_dist_bugs_tf_and_torch branch September 9, 2023 06:26
@sven1977 sven1977 mentioned this pull request Sep 11, 2023
Closed
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
@sven1977 @jimthompson5802
[RLlib] Issue 39234: Multi categorical dist bugs tf and torch. (ray-p…
f96ac2b 
…roject#39464)

Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@sven1977
[RLlib] Issue 39234: Multi categorical dist bugs tf and torch. (ray-p…
5815ce8 
…roject#39464)

Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturNiederfahrenhorst ArturNiederfahrenhorst ArturNiederfahrenhorst approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@ArturNiederfahrenhorst ArturNiederfahrenhorst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sven1977 @ArturNiederfahrenhorst