Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Replace deprecated .pieces with updated .fragments #39523

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

ParquetDataset.pieces has been deprecated since PyArrow 5. This PR replaces it with the updated .fragments attribute.

/tmp/ray/session_2023-09-09_18-08-45_602405_2335/runtime_resources/py_modules_files/_ray_pkg_16a18957f9722be1/ray/data/datasource/parquet_datasource.py:270: FutureWarning: 'ParquetDataset.pieces' attribute is deprecated as of pyarrow 5.0.0 and will be removed in a future version. Use the '.fragments' attribute instead

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@scottjlee
Copy link
Contributor

i think there are some failing doctests, but changes generally LGTM

Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!! these warnings were very annoying

Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bveeramani!

python/ray/data/datasource/file_meta_provider.py Outdated Show resolved Hide resolved
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
…into fix-parquet-pieces

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani merged commit 4f39207 into ray-project:master Sep 12, 2023
44 of 49 checks passed
@bveeramani bveeramani deleted the fix-parquet-pieces branch September 12, 2023 00:35
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 12, 2023
…oject#39523)

ParquetDataset.pieces has been deprecated since PyArrow 5. This PR replaces it with the updated .fragments attribute.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…oject#39523)

ParquetDataset.pieces has been deprecated since PyArrow 5. This PR replaces it with the updated .fragments attribute.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants