Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Issue 39421: MultiDiscrete action spaces not supported on new stack. #39534

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Sep 11, 2023

Issue 39421: MultiDiscrete action spaces not supported on new stack.

Closes #39421

Expanded example script to cover MultiDiscrete action spaces as well.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sven1977 sven1977 merged commit 89ac80d into ray-project:master Sep 11, 2023
33 of 41 checks passed
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
… stack. (ray-project#39534)

Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 12, 2023
… stack. (ray-project#39534)

Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
… stack. (ray-project#39534)

Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RLlib] MultiDiscrete Action Space not supported in Ray 2.7
2 participants