Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fixed 'rollout_fragment_length' in pong-example by setting it to 'auto'. #39552

Merged
merged 5 commits into from
Sep 13, 2023
Merged

[RLlib] Fixed 'rollout_fragment_length' in pong-example by setting it to 'auto'. #39552

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96ccc7f
Fixed 'rollout_fragment_length' in pong-example by setting it to 'auto'.
simonsays1980 Sep 11, 2023
0a9b440
Test pong learning PPO
ArturNiederfahrenhorst Sep 12, 2023
1f7398c
Fixed little typo in regression tests for PPO Pong.
simonsays1980 Sep 12, 2023
cf85d33
Merge branch 'master' into pong-benchmark-value-error
simonsays1980 Sep 13, 2023
ea9ec5c
Removed pong test from BUILD, following @sven1977 's comment.
simonsays1980 Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions rllib/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,17 @@ py_test(
)

# PPO

simonsays1980 marked this conversation as resolved.
Show resolved Hide resolved
py_test(
simonsays1980 marked this conversation as resolved.
Show resolved Hide resolved
name = "learning_test_pong_ppo",
main = "tests/run_regression_tests.py",
tags = ["team:rllib", "exclusive", "learning_tests", "learning_tests_pong", "learning_tests_discrete"],
size = "medium",
srcs = ["tests/run_regression_tests.py"],
data = ["tuned_examples/ppo/pong-ppo.yaml.py"],
args = ["--dir=tuned_examples/ppo"]
)

py_test(
name = "learning_tests_cartpole_truncated_ppo",
main = "tests/run_regression_tests.py",
Expand Down
2 changes: 1 addition & 1 deletion rllib/tuned_examples/ppo/pong-ppo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pong-ppo:
vf_clip_param: 10.0
entropy_coeff: 0.01
train_batch_size: 5000
rollout_fragment_length: 20
rollout_fragment_length: auto
sgd_minibatch_size: 500
num_sgd_iter: 10
num_workers: 32
Expand Down