[Data] Fall back to fetch files info in parallel for multiple directories #39592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21
requested review from
ericl,
scv119,
amogkam,
scottjlee,
bveeramani and
raulchen
as code owners
raulchen
approved these changes
Sep 12, 2023
scottjlee
approved these changes
Sep 13, 2023
Signed-off-by: Cheng Su <scnju13@gmail.com>
Signed-off-by: Cheng Su <scnju13@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ries (ray-project#39592) We have a bug in fetching files information/metadata in https://github.com/ray-project/ray/blob/master/python/ray/data/datasource/file_meta_provider.py#L446-L451 , where it assumes all input paths are file paths. For directory paths, it will be omitted and later exception would be thrown. We found this bug during benchmark work. This PR will fix this issue by falling back to fetch files info in parallel, if there's any directory path. Signed-off-by: Cheng Su <scnju13@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We have a bug in fetching files information/metadata in https://github.com/ray-project/ray/blob/master/python/ray/data/datasource/file_meta_provider.py#L446-L451 , where it assumes all input paths are file paths. For directory paths, it will be omitted and later exception would be thrown. We found this bug during benchmark work.
This PR will fix this issue by falling back to fetch files info in parallel, if there's any directory path.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.