[RLlib] Issue 35440: JSON output writer should include INFOs. #39632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
sven1977
added
the
tests-ok
kouroshHakha
approved these changes
Sep 21, 2023
…og_env_infos' into issue_35440_json_writer_should_log_env_infos
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Sep 26, 2023
…oject#39632) Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…oject#39632) Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 35440: JSON output writer should include INFOs.
Closes #35440
Solution:
Let's revert some of the changes made in #33896
We do normally NOT assume that users would include tf data in their environments' INFO dicts. This is a pretty extreme assumption and should not lead to a hardcoded exclusion of this important data from the output files. In case some test cases do indeed behave like this, we should adjust these. In case users do want to include non-standard data in their INFO dicts, they should write their own
In/OutputWritersand use those then.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.