Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] TuneController remaining test migration (1/n) #39704

Merged
merged 22 commits into from
Sep 22, 2023
Merged

[tune] TuneController remaining test migration (1/n) #39704

merged 22 commits into from
Sep 22, 2023

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

This PR migrates more tests from test_trial_runner_3.py to the new tune controller.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Kai Fricke added 16 commits September 14, 2023 16:50
testSearcherCorrectReferencesAfterRestore
d4ddab8 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testTrialErrorResumeFalse
7a38618 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testTrialErrorResumeTrue
f9325f9 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testTrialSaveRestore
f9accb5 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testTrialNoCheckpointSave
571c6ed 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testCheckpointWithFunction
066c111 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testCheckpointOverwrite
68618ec 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testExperimentCheckpointWithDatasets
2e02690 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testCheckpointFreqBuffered
0ba5b19 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testCheckpointAtEndNotBuffered
7b15d31 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testUserCheckpoint
dad216d 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testUserCheckpointBuffered
53f7d37 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testCheckpointAutoPeriod
22af3b0 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testCloudCheckpointForceWithNumToKeep
4a9a87f 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testForcedCloudCheckpointSyncTimeout
11bf1a4 
Signed-off-by: Kai Fricke <kai@anyscale.com>
testPeriodicCloudCheckpointSyncTimeout
1c55ded 
Signed-off-by: Kai Fricke <kai@anyscale.com>
Kai Fricke added 6 commits September 15, 2023 15:44
searcher utils
7e6dc8b 
Signed-off-by: Kai Fricke <kai@anyscale.com>
Merge remote-tracking branch 'upstream/master' into tune/tune-control…
b20550f 
…ler-tests
lint
d758562 
Signed-off-by: Kai Fricke <kai@anyscale.com>
Merge remote-tracking branch 'upstream/master' into tune/tune-control…
74642f6 
…ler-tests
fix test
b6f5bc3 
Signed-off-by: Kai Fricke <kai@anyscale.com>
test_pause_resume_trial
8220f8e 
Signed-off-by: Kai Fricke <kai@anyscale.com>
matthewdeng
matthewdeng approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@krfricke krfricke merged commit af12c2f into ray-project:master Sep 22, 2023
58 of 62 checks passed
@krfricke krfricke deleted the tune/tune-controller-tests branch September 22, 2023 00:47
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 26, 2023
@krfricke @simonsays1980
[tune] TuneController remaining test migration (1/n) (ray-project#39704)
3e36e47 
This PR migrates more tests from test_trial_runner_3.py to the new tune controller.

Signed-off-by: Kai Fricke <kai@anyscale.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@krfricke
[tune] TuneController remaining test migration (1/n) (ray-project#39704)
8dafbb7 
This PR migrates more tests from test_trial_runner_3.py to the new tune controller.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@justinvyu justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

Assignees

@justinvyu justinvyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krfricke @matthewdeng @justinvyu