Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] ray init sigterm #39816

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Conversation

jonathan-anyscale
Copy link
Contributor

@jonathan-anyscale jonathan-anyscale commented Sep 22, 2023

Why are these changes needed?

Additional update on https://github.com/ray-project/ray/pull/39482/files
sigterm handler can only be run in main thread of driver process, so add checker before setting one

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
@jonathan-anyscale jonathan-anyscale changed the title ray init sigterm [Core] ray init sigterm Sep 22, 2023
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
@jjyao
Copy link
Contributor

jjyao commented Sep 27, 2023

Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
@jjyao
Copy link
Contributor

jjyao commented Sep 28, 2023

Lint failed



python/ray/tests/test_tls_auth.py:142:5: F841 local variable 'out' is assigned to but never used
--
  | 🚨 Error: The command exited with status 123

Could you also update the PR description to be more descriptive.

Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
@jjyao jjyao merged commit 59c36be into ray-project:master Sep 28, 2023
78 of 84 checks passed
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Additional update on ray-project#39482
sigterm handler can only be run in main thread of driver process, so add checker before setting one

Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants