[data] add flag to skip get_object_locations for metrics #39884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2023 15:22
Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
Zandew
changed the title
scottjlee
approved these changes
Sep 27, 2023
scottjlee
approved these changes
Sep 27, 2023
scottjlee
requested review from
ericl,
scv119,
c21,
amogkam,
bveeramani,
raulchen and
stephanie-wang
as code owners
Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
raulchen
reviewed
Sep 27, 2023
python/ray/experimental/locations.py
Outdated
| # If this is for purely metrics use, we can skip the call for performance. | ||
| if ( | ||
| skip_get_locations | ||
| and not ray.data.context.DataContext.get_current().enable_get_object_locations_for_metrics |
There was a problem hiding this comment.
this function is supposed to be used by all Ray libs, not only Data. So let's not add data-specific logic here.
I guess we don't need to touch this function at all. We can just skip calling it in Data code.
|
@Zandew @scottjlee btw, do you know why this is causing failures now? what changed? |
It may be the additional calls to |
Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
Zandew
changed the title
scottjlee
approved these changes
Sep 27, 2023
Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
raulchen
approved these changes
Sep 27, 2023
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…#39884) Adds the flag `ENABLE_GET_OBJECT_LOCATIONS_FOR_METRICS` to `DataContext`. If set, this flag skips the `get_object_locations` call if the result is used only for metrics. --------- Signed-off-by: Andrew Xue <andrewxue@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds the flag
ENABLE_GET_OBJECT_LOCATIONS_FOR_METRICStoDataContext.If set, this flag skips the
get_object_locationscall if the result is used only for metrics.Related issue number
Closes #39596
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.