Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Train/Data] Deprecate legacy DatasetConfig #39963

Merged
merged 5 commits into from
Oct 5, 2023
Merged

[Train/Data] Deprecate legacy DatasetConfig #39963

merged 5 commits into from
Oct 5, 2023

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Sep 29, 2023

Deprecates the legacy DatasetConfig

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam
update
e057120 
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@amogkam
remove more
a4d9dd6 
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 2, 2023
@amogkam
fix
ad42c6d 
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@amogkam
Merge branch 'master' of github.com:ray-project/ray into deprecate-da…
ac45905 
…taset-config

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@amogkam
fix
477127f 
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@bveeramani bveeramani mentioned this pull request Oct 5, 2023
Merged
12 tasks
@amogkam amogkam merged commit 85f3d98 into ray-project:master Oct 5, 2023
57 of 62 checks passed
@amogkam amogkam deleted the deprecate-dataset-config branch October 5, 2023 17:32
Zandew pushed a commit to Zandew/ray that referenced this pull request Oct 10, 2023
@amogkam
[Train/Data] Deprecate legacy DatasetConfig (ray-project#39963)
6c3b640 
Deprecates the legacy DatasetConfig

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@amogkam
[Train/Data] Deprecate legacy DatasetConfig (ray-project#39963)
d2e89c4 
Deprecates the legacy DatasetConfig

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

@stephanie-wang stephanie-wang

@c21 c21

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amogkam @ericl @stephanie-wang @c21