Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix rllib_contrib warnings. #39978

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Sep 29, 2023

Fix rllib_contrib warnings.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 assigned sven1977 and unassigned sven1977 Oct 4, 2023
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, otherwise good to go!

rllib/algorithms/algorithm_config.py Outdated Show resolved Hide resolved
rllib/utils/tests/test_checkpoint_utils.py Outdated Show resolved Hide resolved
@sven1977 sven1977 closed this Oct 14, 2023
@sven1977 sven1977 reopened this Oct 14, 2023
…e65_pkl_msgpack_conversion_fails_due_to_gym_space
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 changed the title [RLlib] AlgorithmConfig serialization should be able to handle possible spaces within env_config. [RLlib] Fix rllib_contrib warnings. Oct 24, 2023
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
…e65_pkl_msgpack_conversion_fails_due_to_gym_space
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
…e65_pkl_msgpack_conversion_fails_due_to_gym_space
@sven1977 sven1977 merged commit a1decc1 into ray-project:master Oct 26, 2023
20 of 25 checks passed
@sven1977 sven1977 deleted the issue65_pkl_msgpack_conversion_fails_due_to_gym_space branch October 26, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants