Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] Add function arg params to map and flat_map #40010

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

Zandew
Copy link
Contributor

@Zandew Zandew commented Oct 2, 2023

Why are these changes needed?

Adds fn_args, fn_kwargs, fn_constructor_kwargs to Dataset.map and Dataset.flat_map, making it them have the same interface as Dataset.map_batches (other than batch specific args).

Related issue number

Closes #38763

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
@scottjlee
Copy link
Contributor

@c21 to review and merge, thanks!

@Zandew Zandew marked this pull request as ready for review October 3, 2023 00:47
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c21 c21 merged commit 56337e0 into ray-project:master Oct 16, 2023
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data] Dataset.map and map_batches args don't match
3 participants