[Data] Remove legacy iteration code path #40013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen and
stephanie-wang
as code owners
amogkam
reviewed
Oct 3, 2023
| @@ -3975,9 +3973,7 @@ def to_tf( | |||
| prefetch_batches: The number of batches to fetch ahead of the current batch | |||
| to fetch. If set to greater than 0, a separate threadpool is used | |||
| to fetch the objects to the local node, format the batches, and apply | |||
| the collate_fn. Defaults to 1. You can revert back to the old | |||
| prefetching behavior that uses `prefetch_blocks` by setting | |||
| `use_legacy_iter_batches` to True in the :class:`~ray.data.DataContext`. | |||
There was a problem hiding this comment.
Also remove the deprecated prefetch_blocks args from all these methods, and the ones in DataIterator
There was a problem hiding this comment.
DatasetPipeline has methods that depend on prefetch_blocks. To minimize code conflicts, I'm planning on sequencing the deprecations like this:
- Remove legacy iteration code path
- Remove
DatasetPipeline - Remove
prefetch_blocks
c21
approved these changes
Oct 4, 2023
Zandew
pushed a commit
to Zandew/ray
that referenced
this pull request
Oct 10, 2023
We changed our iteration implementation in Ray 2.4. To use the old implementation, we exposed a use_legacy_iter_batches option. Since it's been several releases since the change, this PR removes the legacy code path and corresponding option. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
We changed our iteration implementation in Ray 2.4. To use the old implementation, we exposed a use_legacy_iter_batches option. Since it's been several releases since the change, this PR removes the legacy code path and corresponding option. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We changed our iteration implementation in Ray 2.4. To use the old implementation, we exposed a
use_legacy_iter_batchesoption. Since it's been several releases since the change, this PR removes the legacy code path and corresponding option.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.