Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] drop columns before grouping by in Dataset.unique() #40016

Merged

Conversation

Zandew
Copy link
Contributor

@Zandew Zandew commented Oct 2, 2023

Why are these changes needed?

Drops non-group-by columns before aggregation for Dataset.unique so that we do not have to shuffle with extra columns that will get dropped later anyways.

Related issue number

First part of #38764

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
@Zandew Zandew changed the title drop columns before grouping by [data] drop columns before grouping by Oct 3, 2023
Copy link
Contributor

@scottjlee scottjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we update the title to include unique(), and update the description to be more general? (e.g. the dataset will not always have images, but rather we are dropping potentially large columns to improve performance)

@Zandew Zandew changed the title [data] drop columns before grouping by [data] drop columns before grouping by in Dataset.unique() Oct 5, 2023
@Zandew Zandew marked this pull request as ready for review October 5, 2023 20:53
@stephanie-wang stephanie-wang merged commit 02c706f into ray-project:master Oct 11, 2023
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants