[tune] Fix Trial.node_ip property
#40028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
matthewdeng
approved these changes
Oct 3, 2023
| @@ -811,7 +811,7 @@ def has_reported_at_least_once(self) -> bool: | |||
|
|
|||
| @property | |||
| def node_ip(self): | |||
| return self.location.hostname | |||
There was a problem hiding this comment.
Should we add a simple unit test for verifying the attributes exist?
There was a problem hiding this comment.
oh oops I merged this before adding a test -- can do in a followup pr
justinvyu
added a commit
to justinvyu/ray
that referenced
this pull request
Oct 3, 2023
This PR fixes the `Trial.node_ip` property, which didn't work since the `location` attribute got switched to `trial.temporary_state.location`. This PR also does some small cleanups, type annotations, and adds comments. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
8 tasks
GeneDer
pushed a commit
that referenced
this pull request
Oct 3, 2023
This PR fixes the `Trial.node_ip` property, which didn't work since the `location` attribute got switched to `trial.temporary_state.location`. This PR also does some small cleanups, type annotations, and adds comments. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
This PR fixes the `Trial.node_ip` property, which didn't work since the `location` attribute got switched to `trial.temporary_state.location`. This PR also does some small cleanups, type annotations, and adds comments. Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes the
Trial.node_ipproperty, which didn't work since thelocationattribute got switched totrial.temporary_state.location. This PR also does some small cleanups, type annotations, and adds comments.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.