Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] estimate blocks for limit and union operator #40072

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

Zandew
Copy link
Contributor

@Zandew Zandew commented Oct 3, 2023

Why are these changes needed?

We estimate # of blocks outputted for MapOperator, but it depends on the num_outputs_total of it's input dependency. If this method is allowed to return None, then the output blocks of any operator following it cannot be estimated.

This pr estimates the number of blocks outputted from a LimitOperator using the rule: _consumed_rows / _limit = _cur_output_bundles / *total_output_bundles*. This and UnionOperator were the only other operators that returned None, so now num_outputs_total will always return an int.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
@Zandew Zandew marked this pull request as ready for review October 5, 2023 00:29
@Zandew Zandew changed the title [data] estimate blocks for limit operator [data] estimate blocks for limit and union operator Oct 5, 2023
@raulchen raulchen merged commit 034215f into ray-project:master Oct 10, 2023
40 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants