Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] remove TuneRichReporter #40169

Merged
merged 3 commits into from
Oct 17, 2023
Merged

[tune] remove TuneRichReporter #40169

merged 3 commits into from
Oct 17, 2023

Conversation

matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Oct 6, 2023 •
edited
Loading

Why are these changes needed?

Removing this since it's not being used/maintained. 馃槩

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@matthewdeng
[tune] remove TuneRichReporter
8d70d54 
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng matthewdeng marked this pull request as ready for review October 6, 2023 01:52
matthewdeng and others added 2 commits October 17, 2023 10:12
@matthewdeng
Merge branch 'master' into tune-rich
630513c 
Signed-off-by: matthewdeng <matt@anyscale.com>
@matthewdeng
Update tune.py
da63c9d
@matthewdeng matthewdeng added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Oct 17, 2023
@matthewdeng matthewdeng merged commit c91ee0f into ray-project:master Oct 17, 2023
40 of 50 checks passed
@matthewdeng matthewdeng deleted the tune-rich branch October 17, 2023 20:53
@rickyyx rickyyx mentioned this pull request Oct 26, 2023
Closed
jonathan-anyscale pushed a commit to jonathan-anyscale/ray that referenced this pull request Oct 26, 2023
@matthewdeng @jonathan-anyscale
[tune] remove TuneRichReporter (ray-project#40169)
1e1bf4d 
Signed-off-by: matthewdeng <matt@anyscale.com>
jonathan-anyscale pushed a commit to jonathan-anyscale/ray that referenced this pull request Oct 26, 2023
@matthewdeng @jonathan-anyscale
[tune] remove TuneRichReporter (ray-project#40169)
da2fec8 
Signed-off-by: matthewdeng <matt@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshiyyya woshiyyya woshiyyya approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@krfricke krfricke Awaiting requested review from krfricke

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@amogkam amogkam Awaiting requested review from amogkam

@Yard1 Yard1 Awaiting requested review from Yard1

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@justinvyu justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

Assignees

@xwjiang2010 xwjiang2010

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewdeng @woshiyyya @xwjiang2010